Skip to content

Commit 0fdc5fb

Browse files
Keen Yee Liauatscott
authored andcommitted
fix: remove message about disabled LS if ngcc fails (#1359)
The log message is misleading because LS is enable even if ngcc fails. (cherry picked from commit 08a5aec)
1 parent ba13858 commit 0fdc5fb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

server/src/session.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1123,9 +1123,9 @@ export class Session {
11231123
success = true;
11241124
} catch (e) {
11251125
this.error(
1126-
`Failed to run ngcc for ${configFilePath}:\n` +
1127-
` ${e.message}\n` +
1128-
` Language service will remain disabled.`);
1126+
`Failed to run ngcc for ${
1127+
configFilePath}, language service may not operate correctly:\n` +
1128+
` ${e.message}`);
11291129
} finally {
11301130
this.connection.sendProgress(NgccProgressType, NgccProgressToken, {
11311131
done: true,
@@ -1169,4 +1169,4 @@ function isTypeScriptFile(path: string): boolean {
11691169

11701170
function isExternalTemplate(path: string): boolean {
11711171
return !isTypeScriptFile(path);
1172-
}
1172+
}

0 commit comments

Comments
 (0)