Refactor cycle breaking (visited tracking) in SubresourceOperationFactory #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHPStan failure should be addressed in a separate PR. |
soyuka
approved these changes
Jul 24, 2017
meyerbaptiste
previously requested changes
Jul 24, 2017
|
|
||
| $this->computeSubresourceOperations($subresourceClass, $tree, $rootResourceClass, $operation, $visiting); | ||
| $this->computeSubresourceOperations($subresourceClass, $tree, $rootResourceClass, $operation, array_merge($visited, [$visiting])); |
There was a problem hiding this comment.
$visited[] = $visiting;
$this->computeSubresourceOperations(..., $visited);Is it not better for performance?
There was a problem hiding this comment.
No, that would give the wrong result. We could of course use another variable.
There was a problem hiding this comment.
Hum, I think I missed something here... Why is the result wrong? It's not an associative array here, right?
There was a problem hiding this comment.
The result would be wrong because we have a loop, if we modify the $visited array in place it'd affect the other properties.
There was a problem hiding this comment.
Oh sorry, I missed the loop! BTW it's better like this with an associative array! 👍
teohhanhui
force-pushed
the
refactor-subresource-cycle-breaking
branch
from
9a8de56 to
f6fc45d
Compare
meyerbaptiste
approved these changes
Jul 24, 2017
|
Merged in #1283 Thanks @teohhanhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tory
Refactor with visited tracking logic which is much easier to follow.