Fix/psr 6 cache subresource #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
soyuka
commented
Jul 24, 2017
soyuka
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | na |
| License | MIT |
| Doc PR | na |
| @@ -36,7 +36,7 @@ | |||
| <argument type="service" id="service_container" /> | |||
| <argument>%api_platform.formats%</argument> | |||
| <argument>%api_platform.resource_class_directories%</argument> | |||
| <argument type="service" id="api_platform.subresource_operation_factory" /> | |||
| <argument type="service" id="api_platform.subresource_operation_factory.cached" /> | |||
There was a problem hiding this comment.
Why? api_platform.subresource_operation_factory is decorated so you'll have an instance of CachedSubresourceOperationFactory, nop?
There was a problem hiding this comment.
Hmm yeah you're right, what was I thinking... Monday.
soyuka
force-pushed
the
fix/psr-6-cache-subresource
branch
from
789cff5 to
e93a9d1
Compare
meyerbaptiste
approved these changes
Jul 24, 2017
…' into fix/psr-6-cache-subresource
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
…esource Fix/psr 6 cache subresource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.