Add books list feature as example #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The generator has been designed to be used with Bootstrap, maybe should we install it instead? |
|
I redesigned the default books list according to the welcome template, to illustrate how to use a |
|
If you want to update this theme using bootstrap, I think it should be in a separate PR |
|
Actually, Bootstrap should already be available: https://github.com/api-platform/api-platform/blob/master/client/package.json#L6-L7 This has been designed for this usage from the ground. |
|
But revamping the demo theme using bootstrap should be out of this PR |
|
There are no revamping necessary. The generated code already supports Bootstrap. |
dunglas
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #62
This PR only implements a feature presenting a list of books (no delete/create/edit/show) as an example, using
@api-platform/client-generator.The main theme remains the same as the welcome page (cf. Theme.js as template).