Fix zsh dashes in command names #284
Conversation
There was a problem hiding this comment.
Thanks for tackling this, @adellibovi! 👏 A couple notes below.
| #compdef \(type._commandName) | ||
| #compdef \(commandName) |
There was a problem hiding this comment.
I don't think this part can change — IIUC the #compdef tells Zsh what command the completions are for, so they need to match the executable.
| local context state state_descr line | ||
| _\(type._commandName)_commandname=$words[1] | ||
| _\(commandName)_commandname=$words[1] |
There was a problem hiding this comment.
As far as I understand it, this is the only part that needs to change, since dashes are allowed in the function names, just not as a variable name. Can you still reproduce the issue if you only change this part here? As an extra benefit, this smaller change wouldn't cause problems for people who declare both sub-command and sub_command subcommands (which is a bad idea, but it will surely happen eventually).
There was a problem hiding this comment.
You are right, this is the only required changes. I made the change and tried locally :) Thanks for catching it @natecook1000. PR updated!
adellibovi
force-pushed
the
fix-zsh-dash-command-name
branch
from
f47a00f to
2239419
Compare
|
@swift-ci Please test |
Hi, this PR fixes #277
Checklist