Fixed custom completion not working in zsh when command name contains a dash

[CraigSiemens]

Related issues and PRs

• Dashes in command names break completion scripts #277
• Fix zsh dashes in command names #284

Description

This adds onto the fix from #284 that added support for commands with dashes in the name.

When getting completions for an argument using CompletionKind.custom(...) an error occurs. #284 updated a variable but missed updating where that variable is used to also escape the command name.

This updates the usage of that variable to also escape the command name and updates the tests to check for it.

Example

If I have a command called cli-tools with an argument that has a CompletionKind.custom(...), typing cli-tools a then pressing tab will produce the following error.

cli-tools a_custom_completion:1: command not found: -tools_commandname
_custom_completion:1: command not found: -tools_commandname
  cli-tools a

Checklist

• I've added at least one test that validates that my change is working, if appropriate
• I've followed the code style of the rest of the project
• I've read the Contribution Guidelines
• I've updated the documentation if necessary

[natecook1000]

Thanks for this fix, @CraigSiemens!

[natecook1000]

@swift-ci Please test

[CraigSiemens]

@natecook1000 Is there's anything on my side that's holding this up from being merged? I'm just curious since this PR's been open for over a month.

[natecook1000]

@swift-ci Please test

[natecook1000]

@CraigSiemens Nothing on your end! Merging once green 👍🏻