[4.1] Modernized the Xcode project config and prepared for fixes to build-script. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update xcode-playground-support for SE-0054
Minor fix on LoggerFormat.md:81
SourceKit currently is only able to provide code completion in `import` statements for Clang modules. As a result, to ensure that PlaygroundSupport shows up in code completion, include an empty umbrella header. This causes PlaygroundSupport.framework to provide a Clang module in addition to the Swift module. As part of this commit, also fixed a handful of build settings in the PlaygroundSupport_* targets.
There's no reason why this framework needs to be built with safety checks disabled.
…o the MODULEMAP_FILE and MODULEMAP_PRIVATE_FILE build settings. Xcode natively understands module maps, so it's better to use that support directly instead of doing something custom. This prevents issues building PlaygroundLogger with the new build system in Xcode 9. This addresses <rdar://problem/34019263>.
…e project. These were in place to work around a long-since-fixed Xcode bug, so they're no longer necessary.
…ound* targets. Since these frameworks are intended to be linked, their Swift symbols probably shouldn't be stripped.
…ygroundSupport Xcode projects. This is to centralize some build settings, including build settings related to the install path and runpath search paths. As part of this, removed build setting overrides which are now redundant.
This allows any of the configurations to build (or not build) the tests into the PlaygroundLogger framework. This is for <rdar://problem/36512531>.
This is in aid of upcoming build-script changes which will build PlaygroundSupport and PlaygroundLogger together. This is for <rdar://problem/36512531>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings swift-4.1-branch up-to-date with the latest content on master which is not dependent on changes in swift master (i.e. before Joe's changes to update the PlaygroundLogger tests for the context descriptor output change).
This pulls in a couple other minor fixes which should have been pulled in in re-branches from master, plus my changes to modernize the Xcode project structure in this repo and to establish a workspace and schemes for use in build-script.