[4.1] [build-script] Fix how the playground frameworks build in build-script. #14817
Conversation
…undLogger on Linux. As far as I can tell, this never worked, so removing it cannot break anything. Now PlaygroundLogger is treated similarly to PlaygroundSupport, directly referencing xcodebuild instead of indirecting through variables. This commit also introduces explicit error messages when attempting to build PlaygroundLogger or PlaygroundSupport for non-Darwin platforms. This addresses <rdar://problem/36594779>. (cherry picked from commit 9bc45e1)
…ucts. These don't make sense to build separately, and indeed it's likely that PlaygroundLogger will soon depend on PlaygroundSupport. As a result, build them as one product (playgroundsupport) in build-script. Aside from removing the playgroundlogger product, this otherwise continues to build PlaygroundLogger and PlaygroundSupport the same way. This is for <rdar://problem/36512531>. (cherry picked from commit 806c01d) Conflicts: utils/build_swift/driver_arguments.py
…built. Instead of building separately, they are now built together using a new workspace with new schemes. As a result, xcodebuild is now invoked once per-platform, allowing for platform-specific build setting and architecture overrides. This addresses <rdar://problem/36512531>. (cherry picked from commit 3a0eaea)
|
Please test with the following PRs: apple/swift-xcode-playground-support#22 @swift-ci Please test |
|
@Rostepher @shahmishal If one of y'all could review this for Swift 4.1 nomination that would be great -- I need to nominate this build-script change for 4.1 as I need to bring swift-xcode-playground-support's swift-4.1-branch up to date with master to accommodate changes to support SE-0198 in PlaygroundLogger. |
|
LGTM! FYI - swift-4.1-branch is under CCC. |
|
• Explanation: In preparation for landing the new PlaygroundLogger implementation on swift-4.1-branch, we need to bring swift-xcode-playground-support's swift-4.1-branch up-to-date with the basis of that implemenation (i.e. the modernized project structure, primarily). This change brings swift-xcode-playground-support/swift-4.1-branch up-to-date with the latest commit that's not solely aligned with master. This also pulls in changes to build-script and build-script-impl on swift/swift-4.1-branch to support building the latest and greatest swift-xcode-playground-support content. |
This PR does three things by pulling in the changes from #14123:
This is part of <rdar://problem/37861670>.