[build-script] Fix how the playground frameworks build in build-script. #14123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…undLogger on Linux. As far as I can tell, this never worked, so removing it cannot break anything. Now PlaygroundLogger is treated similarly to PlaygroundSupport, directly referencing xcodebuild instead of indirecting through variables. This commit also introduces explicit error messages when attempting to build PlaygroundLogger or PlaygroundSupport for non-Darwin platforms. This addresses <rdar://problem/36594779>.
…ucts. These don't make sense to build separately, and indeed it's likely that PlaygroundLogger will soon depend on PlaygroundSupport. As a result, build them as one product (playgroundsupport) in build-script. Aside from removing the playgroundlogger product, this otherwise continues to build PlaygroundLogger and PlaygroundSupport the same way. This is for <rdar://problem/36512531>.
…built. Instead of building separately, they are now built together using a new workspace with new schemes. As a result, xcodebuild is now invoked once per-platform, allowing for platform-specific build setting and architecture overrides. This addresses <rdar://problem/36512531>.
|
Please test with the following PR: @swift-ci Please test |
|
Please test with the following PR: @swift-ci build toolchain |
Rostepher
approved these changes
Jan 24, 2018
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
The toolchains built successfully, and I did a sanity check of the macOS toolchain. Going ahead and merging this. |
This was referenced Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Resolves <rdar://problem/36512531>.