Remove dependencies caching from workflows #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After I set up caching in the template workflows, doubts were raised about whether it provided any benefits. I don't know enough about this subject to make a call on that and I have been unable to get any more information on the subject. Since the caching significantly increases the complexity of the workflows, which may make them more difficult to maintain and contribute to, I think it's best to just remove all the caching for now. I hope to eventually be able to revisit this topic and restore caching in any workflows where it is definitely beneficial.
|
Hi @per1234. Your pull request has been detected as something other than a Library Manager submission. A maintainer will need to review it before it can be merged. If you intended to submit a library, please check the instructions and update your pull request if necessary: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I set up caching in the template workflows, doubts were raised about whether it provided any benefits. I don't know
enough about this subject to make a call on that and I have been unable to get any more information on the subject.
Since the caching significantly increases the complexity of the workflows, which may make them more difficult to maintain
and contribute to, I think it's best to just remove all the caching for now. I hope to eventually be able to revisit this
topic and restore caching in any workflows where it is definitely beneficial.
I had intended to remove the caching before deploying the workflows, but then somehow forgot about it, so it slipped through with #6
Resolves #7 (this PR is the result of a very rare situation where the
actions/cachemaintainers intentionally neglected to move the major version ref due to accidental breakage introduced in the v2.1.4 release). If we were keeping the caching we could just disregard the Dependabot PR, but since we don't want the caching anyway the whole situation is irrelevant to this project.