Remove Python dependencies caching step #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the development phase of the previous attempt at setting up an official collection of template workflows, I investigated dependencies caching and added it to all workflows where applicable. Afterwards, doubts were raised about whether it provided any benefits. I don't know enough about this subject to make a call on that and I have been unable to get any more information on the subject. Since the caching significantly increases the complexity of the workflows, which may make them more difficult to maintain and contribute to, I think it's best to just remove all the caching for now. I hope to eventually be able to revisit this topic and restore caching in any workflows where it is definitely beneficial. This particular caching step was in the source workflow in the Arduino CLI repository from the very beginning, and was my inspiration for using caching in the first place. However, none of the other workflows with Python dependencies have caching at this point, so having this one as an exception to the otherwise fairly standardized workflow format is confusing.
silvanocerza
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development phase of the previous attempt at setting up an official collection of template workflows, I
investigated dependencies caching and added it to all workflows where applicable. Afterwards, doubts were raised about
whether it provided any benefits. I don't know enough about this subject to make a call on that and I have been unable to
get any more information on the subject.
Since the caching significantly increases the complexity of the workflows, which may make them more difficult to maintain
and contribute to, I think it's best to just remove all the caching for now. I hope to eventually be able to revisit this
topic and restore caching in any workflows where it is definitely beneficial.
This particular caching step was in the source workflow in the Arduino CLI repository from the very beginning, and was my
inspiration for using caching in the first place. However, none of the other workflows with Python dependencies have
caching at this point, so having this one as an exception to the otherwise fairly standardized workflow format is confusing.
Related