Skip to content

Strong name Benchmarks.dll so it can use Kestrel's HttpParser temporarily #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Strong name Benchmarks.dll so it can use Kestrel's HttpParser temporarily #1439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/Benchmarks/AspNetCore.snk
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions src/Benchmarks/Benchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<!-- Prevent the SDK from validating the supported TFM. -->
<NETCoreAppMaximumVersion>99.9</NETCoreAppMaximumVersion>
<NoWarn>0618;NU1605</NoWarn>
<AssemblyOriginatorKeyFile>AspNetCore.snk</AssemblyOriginatorKeyFile>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REVIEW: This change doesn't seem to cause dotnet build to strong name the assembly, but I created the PR anyway to encourage someone to show me the correct way to do this without porting this project to arcade.

</PropertyGroup>

<ItemGroup>
Expand Down