Strong name Benchmarks.dll so it can use Kestrel's HttpParser temporarily #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
commented
Dec 4, 2019
| @@ -19,6 +19,7 @@ | |||
| <!-- Prevent the SDK from validating the supported TFM. --> | |||
| <NETCoreAppMaximumVersion>99.9</NETCoreAppMaximumVersion> | |||
| <NoWarn>0618;NU1605</NoWarn> | |||
| <AssemblyOriginatorKeyFile>AspNetCore.snk</AssemblyOriginatorKeyFile> | |||
There was a problem hiding this comment.
REVIEW: This change doesn't seem to cause dotnet build to strong name the assembly, but I created the PR anyway to encourage someone to show me the correct way to do this without porting this project to arcade.
|
Closing in favor of dotnet/aspnetcore#17573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/aspnetcore#17571 which will make Kestrel.Core's internals visible to the Benchmarks project, but for that to work, the Benchmarks assembly needs to be strong named as far as I'm aware.