Pubternal IHttpHeadersHandler #17573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
requested review from
halter73,
davidfowl,
sebastienros and
jkotalik
github-actions
bot
added
the
api-suggestion
|
FYI @aspnet/http2 IHttpHeadersHandler is something we moved into shared code for HPACK. It was previously a 'pubternal' API in our code base that our benchmarks infrastructure depended on. This PR restores it as a pubternal API in its original namespace until we can come up with a cleaner solution. I used ifdefs so no changes should be required in the runtime repo. |
jkotalik
approved these changes
Dec 4, 2019
|
Is there anyway to confirm by merging this PR that benchmarks will build again? I'd prefer to have that inner loop fast as we have gone back and forth fixing pieces. |
|
@Tratcher Are you planning to open a PR in https://github.com/dotnet/runtime to synchronize these changes? |
This was referenced Dec 4, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution to the pubternal shared code issues.