Skip to content

chore: Support Hostnetwork #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kahirokunn
Copy link

Description of changes:

When I build a vxlan with cilium, the address is not allowed.

https://cert-manager.io/docs/installation/compatibility/#aws-eks
elastic/cloud-on-k8s#1369

This patch is required for custom cni to work at a minimum.

@ack-prow ack-prow bot requested a review from a-hilaly August 2, 2023 01:16
@ack-prow
Copy link

ack-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign redbackthomson for approval by writing /assign @redbackthomson in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from RedbackThomson August 2, 2023 01:16
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2023
@ack-prow
Copy link

ack-prow bot commented Aug 2, 2023

Hi @kahirokunn. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Comment on lines +135 to +140
{{ if .Values.hostNetwork }}
hostNetwork: true
dnsPolicy: ClusterFirstWithHostNet
{{ else }}
hostNetwork: false
{{ end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kahirokunn , thank you for your patch! These files are generated using code-generator, i would suggest to open a PR against code-generator/templates files, that way we can propagate for the change for all the controllers. 👍

@kahirokunn
Copy link
Author

Signed-off-by: kahirokunn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants