Skip to content

Support setting HostNetwork and DnsPolicy using helm chart values #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

Support setting HostNetwork and DnsPolicy using helm chart values #460

merged 1 commit into from
Sep 14, 2023

Conversation

kahirokunn
Copy link
Contributor

@kahirokunn kahirokunn commented Aug 14, 2023 •
edited by a-hilaly
Loading

Issue #, if available:

Description of changes:

  • Support setting HostNetwork and DnsPolicy using helm chart values

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jljaco August 14, 2023 03:22
@ack-prow
Copy link

ack-prow bot commented Aug 14, 2023

Hi @kahirokunn. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2023
@kahirokunn kahirokunn mentioned this pull request Aug 14, 2023
Closed
@kahirokunn
Copy link
Contributor Author

I just want to do this.
https://github.com/aws-controllers-k8s/acm-controller/pull/20/files

@kahirokunn
Copy link
Contributor Author

@a-hilaly Hi!
I would like to contribute to the many repositories of aws-controllers-k8s, can you put me in the org?

a-hilaly
a-hilaly reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kahirokunn - Thank you for your contribution!

I left few comments in-line.

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 8, 2023
@a-hilaly
Copy link
Member

a-hilaly commented Sep 8, 2023 •
edited
Loading

@a-hilaly Hi!
I would like to contribute to the many repositories of aws-controllers-k8s, can you put me in the org?

Unfortunately, the invitation process is automated and only @aws members can also join this org @kahirokunn

@kahirokunn
Copy link
Contributor Author

kahirokunn commented Sep 8, 2023 •
edited
Loading

@a-hilaly
I have addressed the points you made.Thx.

a-hilaly
a-hilaly reviewed Sep 8, 2023
View reviewed changes
@kahirokunn kahirokunn force-pushed the host-network branch 2 times, most recently from 7b829af to fa635a7 Compare September 8, 2023 05:13
a-hilaly
a-hilaly reviewed Sep 8, 2023
View reviewed changes
@kahirokunn
Copy link
Contributor Author

@a-hilaly The test passed!

a-hilaly
a-hilaly reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, i have few suggestions below

@a-hilaly
Copy link
Member

/ping @kahirokunn

@kahirokunn @a-hilaly
chore: Support Hostnetwork and DnsPolicy
7c209ee 
Co-authored-by: kahirokunn <[email protected]>
Co-authored-by: Amine <[email protected]>
@kahirokunn
Copy link
Contributor Author

/pong @a-hilaly

@kahirokunn
Copy link
Contributor Author

/retest

a-hilaly
a-hilaly approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kahirokunn !

@ack-prow ack-prow bot added the approved label Sep 14, 2023
@a-hilaly
Copy link
Member

/test all

@a-hilaly
Copy link
Member

/test apigatewayv2-controller-test

@a-hilaly a-hilaly changed the title chore: Support Hostnetwork and DnsPolicy Support setting HostNetwork and DnsPolicy using helm chart values Sep 14, 2023
jljaco
jljaco approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@jljaco jljaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@ack-prow
Copy link

ack-prow bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, jljaco, kahirokunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 892f29d into aws-controllers-k8s:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

@jljaco jljaco jljaco approved these changes

Assignees

@jljaco jljaco

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kahirokunn @a-hilaly @jljaco