feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134

ib-ak · 2023-03-09T15:21:53Z

Issue #, if available:
1711

Description of changes
vpc endpoint service configuration controller added
RouteTable fields disabled to make it work.

Functionality

create vpc endpoint service
delete vpc endpoint service

Tests
relevant test case added. Separate PR raised to update test-infra. Please merge the test-infra PR and update the requirements.txt before running the test cases.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tion controller added

ack-prow · 2023-03-09T15:22:06Z

Hi @ib-ak. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jaypipes · 2023-03-09T15:29:35Z

generator.yaml

+#      Routes.GatewayId:
+#        references:
+#          resource: InternetGateway
+#          path: Status.InternetGatewayID
+#      Routes.NatGatewayId:
+#        references:
+#          resource: NATGateway
+#          path: Status.NATGatewayID
+#      Routes.TransitGatewayId:
+#        references:
+#          resource: TransitGateway
+#          path: Status.TransitGatewayID
+#      Routes.VpcEndpointId:
+#        references:
+#          resource: VPCEndpoint
+#          path: Status.VPCEndpointID


I think you may have accidentally commented these out :) You need to uncomment this back..

aws-controllers-k8s/community#1718

@ib-ak OK, understood. However, we won't be able to address this PR until that issue has been fixed, since this results in backwards-incompatible changes to the RouteTable CRD...

@jaypipes We have an open issue where RouteTable blocks the build. I have linked it here.

a-hilaly · 2023-03-09T16:46:22Z

/ok-to-test

a-hilaly · 2023-03-09T16:47:34Z

Yeah we'll have to fix the code-generator part that's breaking ec2 - (or at least get rid of the panic). /cc @RedbackThomson

a-hilaly · 2023-04-25T14:56:26Z

/retest

a-hilaly · 2023-04-25T14:56:31Z

/test all

a-hilaly

Awesome start on this! Thank you!
We just need to fix e2e tests and things should work smoothly

a-hilaly · 2023-04-25T15:12:16Z

test/e2e/tests/test_vpc_endpoint_service_configuration.py

+
+from acktest.resources import random_suffix_name
+from acktest.k8s import resource as k8s
+from acktest.bootstrapping.elbv2 import NetworkLoadBalancer


@ib-ak This is not something we have in acktest for now. Do you mind PRing to add NetworkLoadBalancer ?

https://github.com/aws-controllers-k8s/test-infra/blob/main/src/acktest/bootstrapping/elbv2.py

ack-prow · 2023-04-25T15:13:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, ib-ak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [A-Hilaly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ack-prow · 2023-05-18T16:55:47Z

@ib-ak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ec2-metadata-file-test	`3742f13`	link	true	`/test ec2-metadata-file-test`
ec2-kind-e2e	`3742f13`	link	true	`/test ec2-kind-e2e`
ec2-codespell	`3742f13`	link	true	`/test ec2-codespell`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-bot · 2023-11-14T17:26:37Z

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ib-ak

… functionality (#172) Related to: - aws-controllers-k8s/community#1711 Description of changes: This is the continuation of PR #134 (Credit to @ib-ak !). This PR: - Adds the `VPCEndpointService` custom resource from the code-generator - Adds the field `spec.allowedPrincipals` of type `[]string`, which allows the user to specify a list of ARNs to share the VPC Endpoint Service with. Any Principals added to this list will have the VPC Endpoint Service shared with them. This field also ensures that Principals that are removed from the list have the VPC Endpoint Service share removed. - Tests are added for creation/deletion and for adding/deleting Principals to the Allowed List By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ib-ak

… functionality (aws-controllers-k8s#172) Related to: - aws-controllers-k8s/community#1711 Description of changes: This is the continuation of PR aws-controllers-k8s#134 (Credit to @ib-ak !). This PR: - Adds the `VPCEndpointService` custom resource from the code-generator - Adds the field `spec.allowedPrincipals` of type `[]string`, which allows the user to specify a list of ARNs to share the VPC Endpoint Service with. Any Principals added to this list will have the VPC Endpoint Service shared with them. This field also ensures that Principals that are removed from the list have the VPC Endpoint Service share removed. - Tests are added for creation/deletion and for adding/deleting Principals to the Allowed List By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ib-ak added 2 commits March 9, 2023 09:02

feat(VpcEndpointServiceConfiguration): vpc endpoint service configura…

b37a81d

…tion controller added

Merge branch 'aws-controllers-k8s:main' into main

1fdffc0

ack-prow bot requested review from pdk27 and RedbackThomson March 9, 2023 15:22

ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2023

jaypipes reviewed Mar 9, 2023

View reviewed changes

ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023

pdk27 removed their request for review March 27, 2023 15:55

a-hilaly approved these changes Apr 25, 2023

View reviewed changes

ack-prow bot added the approved label Apr 25, 2023

Merge branch 'aws-controllers-k8s:main' into main

3742f13

This was referenced Aug 23, 2023

Error while generator controller references within lists inside lists aren't supported. crd: "RouteTable", path: "Routes.GatewayID" aws-controllers-k8s/community#1718

Closed

feat: add support for VPCEndpointServiceConfiguration CRD #147

Closed

ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2023

marcdavoli mentioned this pull request Dec 21, 2023

feat(VPCEndpointService): add custom resource and allowedPrincipals functionality #172

Merged

a-hilaly closed this Jan 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134

feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134

Uh oh!

ib-ak commented Mar 9, 2023

Uh oh!

ack-prow bot commented Mar 9, 2023

Uh oh!

jaypipes Mar 9, 2023

Uh oh!

ib-ak Mar 9, 2023

Uh oh!

jaypipes Mar 9, 2023

Uh oh!

ib-ak Mar 9, 2023

Uh oh!

a-hilaly commented Mar 9, 2023

Uh oh!

a-hilaly commented Mar 9, 2023

Uh oh!

a-hilaly commented Apr 25, 2023

Uh oh!

a-hilaly commented Apr 25, 2023

Uh oh!

a-hilaly left a comment

Uh oh!

a-hilaly Apr 25, 2023

Uh oh!

ib-ak May 4, 2023

Uh oh!

ack-prow bot commented Apr 25, 2023

Uh oh!

ack-prow bot commented May 18, 2023

Uh oh!

ack-bot commented Nov 14, 2023

Uh oh!

Uh oh!

feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134

feat(VpcEndpointServiceConfiguration): vpc endpoint service configuration controller added #134

Uh oh!

Conversation

ib-ak commented Mar 9, 2023

Uh oh!

ack-prow bot commented Mar 9, 2023

Uh oh!

jaypipes Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

ib-ak Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

jaypipes Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

ib-ak Mar 9, 2023

Choose a reason for hiding this comment

Uh oh!

a-hilaly commented Mar 9, 2023

Uh oh!

a-hilaly commented Mar 9, 2023

Uh oh!

a-hilaly commented Apr 25, 2023

Uh oh!

a-hilaly commented Apr 25, 2023

Uh oh!

a-hilaly left a comment

Choose a reason for hiding this comment

Uh oh!

a-hilaly Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

ib-ak May 4, 2023

Choose a reason for hiding this comment

Uh oh!

ack-prow bot commented Apr 25, 2023

Uh oh!

ack-prow bot commented May 18, 2023

Uh oh!

ack-bot commented Nov 14, 2023

Uh oh!

Uh oh!