-
Notifications
You must be signed in to change notification settings - Fork 55
feat: add support for VPCEndpointServiceConfiguration CRD #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for VPCEndpointServiceConfiguration CRD #147
Conversation
Hi @cannonpalms. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cannonpalms The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cannonpalms - overall this looks good!
I have few comments bellow.
build_date: "2023-08-25T00:38:30Z" | ||
build_hash: e9c531826f41fa60de8bbbd0490099de3b7d02c5 | ||
go_version: go1.21.0 | ||
version: v0.26.1-12-ge9c5318 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to regenerate the controller using latest commit of code-generator
@@ -0,0 +1,3 @@ | |||
if err = addIDToDeleteRequest(r, input); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is addIDToDeleteRequest
function defined? typical we add custom functions to a file called hooks.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this that this template only generated newTag
, is it intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this controller is already GA, we will need e2e tests for each new resource.
Thank you @a-hilaly for engaging with this PR and providing reviews. I regret to have to tell you that we ended up straying away from ACK for managing our VPCEndpointServices, and lack the bandwidth to give this PR the attention that it requires for landing. I do hope that someone takes up the mantle of aws-controllers-k8s/community#1711 (which, as a side note, has been closed as stale--perhaps that issue should be |
Issue #, if available: aws-controllers-k8s/community#1711
Description of changes: Essentially just recreates #134 but with the benefit of hindsight; this PR does not touch RouteTable CRDs, as the former did. It would seem that the problems resulting from this issue may have been solved, thus rendering us ready to rock.
@jaypipes Would you mind telling me if I've made a poor assumption somewhere? I see in the upstream issue about nested lists that @RedbackThomson was originally slated to work on it. I didn't see any linked PRs to that issue, however, when rebuilding #134 from scratch, I did not need to modify the RouteTable CRD to work around this issue, so perhaps it has been fixed?
Either way, we would love to get this upstreamed. I'd separately love it if someone could comment on the general safety of using a build based off of this PR in production just to gain access to VPCEndpointServiceConfiguration ASAP.
Thank you all, and I look forward to receiving feedback on this PR!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Full context
It is by no means my intention to remove any credit from @ib-ak for this work! GitHub's WYSIWYG editor won't seem to let me tag them, but I hope it is working☹️ . As soon as I type the "dash" in that username, the automatic username suggestions disappear.