Add EC2 Platform Test to Python #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
add-ec2-platform-for-python-ga
branch
from
22a4094 to
840d8a8
Compare
.github/workflows/application-signals-python-e2e-ec2-asg-test.yml
Outdated
Show resolved
Hide resolved
.github/workflows/application-signals-python-e2e-ec2-asg-test.yml
Outdated
Show resolved
Hide resolved
.github/workflows/application-signals-python-e2e-ec2-asg-test.yml
Outdated
Show resolved
Hide resolved
.github/workflows/application-signals-python-e2e-ec2-asg-test.yml
Outdated
Show resolved
Hide resolved
.github/workflows/application-signals-python-e2e-ec2-asg-test.yml
Outdated
Show resolved
Hide resolved
validator/src/main/resources/validations/python/ec2/asg/log-validation.yml
Outdated
Show resolved
Hide resolved
harrryr
force-pushed
the
add-ec2-platform-for-python-ga
branch
from
9da9fe9 to
6c1262a
Compare
harrryr
force-pushed
the
add-ec2-platform-for-python-ga
branch
2 times, most recently
from
1c40b0e to
aeb56e8
Compare
harrryr
force-pushed
the
add-ec2-platform-for-python-ga
branch
from
ef6190d to
b1ebea6
Compare
majanjua-amzn
approved these changes
May 15, 2024
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
aws-observability#64) *Issue #, if available:* Use X-Ray default sampler as default sampler if user has not specified one Requires aws-observability/aws-otel-python-instrumentation#55 to be merged first before this PR can work. *Description of changes:* Use X-Ray default sampler as default sampler if user has not specified one *Testing:* Assume aws-observability/aws-otel-python-instrumentation#55 is merged 1. Enabled span_metrics_processor and added debug statement to print out Sampled status of a span in `on_start()` ``` # aws_span_metrics_processor.py if span.get_span_context().trace_flags.sampled: print("sampled") ``` 2. Replaced resource detectors and manually set resource with service.name=test-service-name and build ADOT SDK 3. Setup OTel collector with XRay proxy for sampling and AWS credentials 4. In AWS account, create sampling rule to match service_name=test-service-name 5. Setup sample app in `sample-applications/simple-client-server/server_automatic_s3client.py` 6. Update `sample-applications/simple-client-server/client.py` to call server/sample-app a variable number of times to verify sampling rule is applied 7. Repeat 6 after changing sampling rule rate/reservoir By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The Java OTEL has E2E testing for telemetry generated through a sample app managed by auto scaling groups. Do the same for Python
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/9065863403
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/9088391496/job/24977861172
Test run: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/9088751078/job/24978832240
Note: Test run was ran with the branch
add-ec2-platform-for-python-ga. Once successful test was ran, switched it back toga-python. Current test shows as failing but once merged back toga-pythonit should work againBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.