fix: add instruction file support in getObject async #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Feb 18, 2023
## 1.0.0 (2023-02-18) ### Features * Adds Async client, starting with DeleteObject(s) ([#54](#54)) ([c7120e1](c7120e1)) * Adds CBC stream decryption ([#25](#25)) ([9970104](9970104)) * Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d)) * implement AES-GCM streaming ([#45](#45)) ([d0bcd38](d0bcd38)) * implement CBC decryption in async getObject ([#59](#59)) ([4fd2fa8](4fd2fa8)) * implement getObject async ([#56](#56)) ([b9834ce](b9834ce)) * implement putObject in Async client ([#57](#57)) ([f233d72](f233d72)) * Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb)) * Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac)) * multi-part putObject ([#53](#53)) ([281f383](281f383)) * Multipart Upload ([#43](#43)) ([7e42811](7e42811)) ### Maintenance * Create workflow to release S3EC to Github ([#52](#52)) ([ef8effb](ef8effb)) ### Fixes * add instruction file support in getObject async ([#69](#69)) ([ee61abd](ee61abd)) * address some edge cases to fix async CBC ranged gets ([#70](#70)) ([1da1cae](1da1cae)) * Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Feb 20, 2023
## 1.0.0 (2023-02-20) ### Features * Adds Async client, starting with DeleteObject(s) ([#54](#54)) ([c7120e1](c7120e1)) * Adds CBC stream decryption ([#25](#25)) ([9970104](9970104)) * Configurable SecureRandom ([#40](#40)) ([90cab2d](90cab2d)) * implement AES-GCM streaming ([#45](#45)) ([d0bcd38](d0bcd38)) * implement CBC decryption in async getObject ([#59](#59)) ([4fd2fa8](4fd2fa8)) * implement getObject async ([#56](#56)) ([b9834ce](b9834ce)) * implement putObject in Async client ([#57](#57)) ([f233d72](f233d72)) * Implement Ranged-Get ([#31](#31)) ([65331fb](65331fb)) * Introduce delayed authentication ([#23](#23)) ([b8eedac](b8eedac)) * multi-part putObject ([#53](#53)) ([281f383](281f383)) * Multipart Upload ([#43](#43)) ([7e42811](7e42811)) ### Maintenance * Create workflow to release S3EC to Github ([#52](#52)) ([ef8effb](ef8effb)) ### Fixes * add instruction file support in getObject async ([#69](#69)) ([ee61abd](ee61abd)) * address some edge cases to fix async CBC ranged gets ([#70](#70)) ([1da1cae](1da1cae)) * Guard against using another S3EC as wrappedClient ([#36](#36)) ([30cf9b1](30cf9b1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes: add instruction file support in getObject async
This was already done in #63 but that PR also added some refactoring which I don't want to merge just yet.
Also, we should only create the client once, not per request, so I moved the client instantiation inside the pipeline builder.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.