feat: extend delegating client to enable non-encrypted API operations… #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in default and async encrypion clients
kessplas
commented
Feb 28, 2023
| @@ -123,11 +125,6 @@ public CompletableFuture<DeleteObjectsResponse> deleteObjects(DeleteObjectsReque | |||
| .build()); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
nb: the delegating client's implementation is final but also identical to this one.
kessplas
commented
Feb 28, 2023
| @@ -206,11 +211,6 @@ public AbortMultipartUploadResponse abortMultipartUpload(AbortMultipartUploadReq | |||
| return _multipartPipeline.abortMultipartUpload(request); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
nb: the delegating client's implementation is final but also identical to this one.
texastony
approved these changes
Mar 1, 2023
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
## [2.2.0](v2.1.1...v2.2.0) (2023-03-01) ### Features * Add S3CrtAsyncClient as MultipartPutobject ([#90](#90)) ([24be141](24be141)) * extend delegating client to enable non-encrypted API operations in default and async encrypion clients ([#94](#94)) ([ba78c2c](ba78c2c)) ### Maintenance * bump AWS SDK v2 deps and make S3 non-optional ([#93](#93)) ([9d0c495](9d0c495)) * change algorithm suite IDs to match the specification ([#86](#86)) ([322e88c](322e88c)) * cleanup some test code ([#92](#92)) ([ba3be52](ba3be52)) ### Fixes * Revert "AWS S3 Encryption Client 1.0.1 Release -- $(date +%Y-%m-%d)" ([0d750cb](0d750cb)) * Revert "AWS S3 Encryption Client 1.0.0 Release -- $(date +%Y-%m-%d)" ([80bc1fa](80bc1fa)) * convert to a blocking input stream instead of going through a by… ([#96](#96)) ([eea77c1](eea77c1)) * pass exception from doFinal to wrapped subscriber to avoid hanging ([#95](#95)) ([7c64a9f](7c64a9f)) * Remove default wrapped client ([#81](#81)) ([287a63e](287a63e)) * rename to Amazon S3 Encryption Client ([#89](#89)) ([4950731](4950731))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in default and async encryption clients
Issue #, if available:
n/a
Description of changes:
In order to allow the S3 EC to function as a more "generic" S3 client, e.g. one that supports control plane operations and data plane operations which do not make sense to have encryption, we need to extend the delegating client class instead of merely implementing the interface.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.