Updates: BYO examples to remove docker restart #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckev-amazon
reviewed
Feb 2, 2018
| @@ -13,6 +13,9 @@ then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| chmod +x decision_trees/train | |||
| chmod +x decision_trees/serve | |||
|
|
|||
There was a problem hiding this comment.
Is this a related change?
There was a problem hiding this comment.
I snuck that one in there. It was a point of misalignment between the notebook's shell command and the build_and_push.sh that was called out in this Issue.
There was a problem hiding this comment.
Sounds good! Not an issue, from my perspective, as long as both issues are referenced by the commit (which you've done).
mckev-amazon
approved these changes
Feb 2, 2018
atqy
pushed a commit
to atqy/amazon-sagemaker-examples
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both notebooks and build_and_push.sh in fresh SageMaker Notebook Instance and both worked.