Skip to content

Updates: BYO examples to remove docker restart #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2018
Merged

Updates: BYO examples to remove docker restart #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions advanced_functionality/r_bring_your_own/r_bring_your_own.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,6 @@
"# Get the login command from ECR and execute it directly\n",
"$(aws ecr get-login --region ${region} --no-include-email)\n",
"\n",
"# On a SageMaker Notebook Instance, the docker daemon may need to be restarted in order\n",
"# to detect your network configuration correctly. (This is a known issue.)\n",
"if [ -d \"/home/ec2-user/SageMaker\" ]; then\n",
" sudo service docker restart\n",
"fi\n",
"\n",
"# Build the docker image locally with the image name and then push it to ECR\n",
"# with the full name.\n",
"docker build -t ${algorithm_name} .\n",
Expand Down
9 changes: 3 additions & 6 deletions advanced_functionality/scikit_bring_your_own/container/build_and_push.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ then
exit 1
fi

chmod +x decision_trees/train
chmod +x decision_trees/serve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a related change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I snuck that one in there. It was a point of misalignment between the notebook's shell command and the build_and_push.sh that was called out in this Issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Not an issue, from my perspective, as long as both issues are referenced by the commit (which you've done).

# Get the account number associated with the current IAM credentials
account=$(aws sts get-caller-identity --query Account --output text)

Expand Down Expand Up @@ -44,12 +47,6 @@ $(aws ecr get-login --region ${region} --no-include-email)
# Build the docker image locally with the image name and then push it to ECR
# with the full name.

# On a SageMaker Notebook Instance, the docker daemon may need to be restarted in order
# to detect your network configuration correctly. (This is a known issue.)
if [ -d "/home/ec2-user/SageMaker" ]; then
sudo service docker restart
fi

docker build -t ${image} .
docker tag ${image} ${fullname}

Expand Down
6 changes: 0 additions & 6 deletions advanced_functionality/scikit_bring_your_own/scikit_bring_your_own.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,12 +271,6 @@
"# Build the docker image locally with the image name and then push it to ECR\n",
"# with the full name.\n",
"\n",
"# On a SageMaker Notebook Instance, the docker daemon may need to be restarted in order\n",
"# to detect your network configuration correctly. (This is a known issue.)\n",
"if [ -d \"/home/ec2-user/SageMaker\" ]; then\n",
" sudo service docker restart\n",
"fi\n",
"\n",
"docker build -t ${algorithm_name} .\n",
"docker tag ${algorithm_name} ${fullname}\n",
"\n",
Expand Down