chore: add codebuild release #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
force-pushed
the
jocorell/add-cb
branch
from
df705c0 to
07c20df
Compare
texastony
reviewed
Jun 8, 2023
|
|
||
| ## 3.0.0-preview-1 2023-06-08 | ||
|
|
||
| ### Features |
There was a problem hiding this comment.
Suggested change
| ### Features | |
| ### Developer Preview |
lavaleri
reviewed
Jun 9, 2023
lavaleri
reviewed
Jun 9, 2023
| - rm -rf ~/.m2/repository/software/amazon/cryptography/aws-cryptographic-material-providers | ||
| - make transpile_implementation_java | ||
| - make transpile_test_java | ||
| - make mvn_local_deploy |
There was a problem hiding this comment.
just confirming that mvn_local_deploy will end up running the Java tests?
There was a problem hiding this comment.
mvn_local_deploy won't run the Java tests; which is why we run them on make test_java and then run the long tests on line 60.
Now that you mention it they are out of order but if at any point they fail we won't publish.
lavaleri
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
depends on #234
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.