Skip to content

chore: Update MPL dependency #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

chore: Update MPL dependency #234

wants to merge 10 commits into from

Conversation

lavaleri
Copy link
Contributor

@lavaleri lavaleri commented Jun 7, 2023

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 16:37 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 17:01 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 22:53 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 22:53 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 22:53 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 22:53 — with GitHub Actions Inactive
@lavaleri lavaleri temporarily deployed to MPL CI June 7, 2023 22:53 — with GitHub Actions Inactive
@lavaleri lavaleri changed the base branch from main to jocorell/add-cb June 7, 2023 23:45
@lavaleri lavaleri changed the base branch from jocorell/add-cb to main June 8, 2023 00:34
@lavaleri lavaleri marked this pull request as ready for review June 8, 2023 00:58
@lavaleri lavaleri requested a review from a team as a code owner June 8, 2023 00:58
texastony
texastony previously approved these changes Jun 8, 2023
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion for the Release Notes.


## 3.0.0-preview-1 2023-06-08

### Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Features
### Developer Preview

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you insist, I'm going to leave this as is. The changelog should normally be a list of "feature/fixes/etc" that line up with our semantic commit messages. Since this is the first release, it makes sense to do something a bit different, but I still think it is reasonable to frame it as "we are introducing this feature. The feature is the whole library"

@lavaleri
Copy link
Contributor Author

lavaleri commented Jun 8, 2023

Closed in favor of #232

@lavaleri lavaleri closed this Jun 8, 2023
@lavaleri lavaleri closed this Jun 9, 2023
@lavaleri lavaleri deleted the update-mpl branch June 9, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants