chore: Add dist-tag to release #1045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the release build will _always_ add the `latest` tag to every release. If a release is for an old version, this will result in the wrong version being tagged as `latest`. This ENV in the build allows for proper tagging.
texastony
reviewed
Oct 31, 2022
Comment on lines
+7
to
+8
| # An explicit distribution tag | ||
| DIST_TAG: "latest" |
There was a problem hiding this comment.
Question: Can this be overridden at some point before the release?
I think that is how CodeBuild works... but I just want to verify.
There was a problem hiding this comment.
Yes. This can be overridden just like the BRANCH variable to release from anything other than upstream :)
josecorella
approved these changes
Oct 31, 2022
|
I think so. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the release build will always add the
latesttag to every release.If a release is for an old version,
this will result in the wrong version being tagged as
latest.This ENV in the build allows for proper tagging.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: