Skip to content

chore: Add dist-tag to release #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion codebuild/release/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ env:
variables:
NODE_OPTIONS: "--max-old-space-size=4096"
BRANCH: "master"
# An explicit distribution tag
DIST_TAG: "latest"
Comment on lines +7 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Can this be overridden at some point before the release?
I think that is how CodeBuild works... but I just want to verify.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This can be overridden just like the BRANCH variable to release from anything other than upstream :)

secrets-manager:
OTP_SECRET_KEY: npm/aws-crypto-tools-ci-bot/2FA:OTP_SECRET_KEY
NPM_TOKEN: npm/aws-crypto-tools-ci-bot/2FA:NPM_TOKEN
Expand Down Expand Up @@ -42,7 +44,7 @@ phases:
# This is going to use the OTP generated above and the NPM_TOKEN
# environment variable. This will only publish things that are
# missing from npm. It is therefore safe to run repeatedly.
- npx lerna publish from-package --yes --otp $OTP
- npx lerna publish from-package --yes --otp $OTP --dist-tag $DIST_TAG
# remove after publishing
- rm .npmrc