API Fixes to update to latest TLS API from aws-c-io #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanHenson
approved these changes
Mar 18, 2019
bretambrose
reviewed
Mar 18, 2019
| @@ -186,7 +186,7 @@ int main(int argc, char *argv[]) | |||
| } | |||
|
|
|||
| auto connectionOptions = tlsCtx.NewConnectionOptions(); | |||
| connectionOptions.server_name = endpoint.c_str(); | |||
| connectionOptions.server_name = aws_string_new_from_c_str(aws_default_allocator(), endpoint.c_str()); | |||
There was a problem hiding this comment.
This is way beyond the scope of this CR, but as a general whine, I dislike the way we don't do full cleanup . Sure, the process ends, but given how people tend to use code samples (cut-and-paste-and-modify), anyone who uses this and embeds it somewhere other than main() is going to naturally have resource issues.
I've seen this in some of the unit tests to, where we don't necessarily call clean_up on various os resource wrappers (or leave them locked, etc...). Those will get the cut-and-paste treatment too.
yourslab
pushed a commit
to yourslab/aws-iot-device-sdk-cpp-v2
that referenced
this pull request
Apr 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #13
Description of changes: API Fixes to update to latest TLS API from aws-c-io
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.