Skip to content

API Fixes to update to latest TLS API from aws-c-io #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2019
Merged

API Fixes to update to latest TLS API from aws-c-io #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f78bf
Added .idea (clion) to gitignore
Mar 18, 2019
fe09ead
Updated samples to match TLS API changes
Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.idea
2 changes: 1 addition & 1 deletion samples/jobs/describe_job_execution/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ int main(int argc, char *argv[])
}

auto connectionOptions = tlsCtx.NewConnectionOptions();
connectionOptions.server_name = endpoint.c_str();
connectionOptions.server_name = aws_string_new_from_c_str(aws_default_allocator(), endpoint.c_str());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way beyond the scope of this CR, but as a general whine, I dislike the way we don't do full cleanup . Sure, the process ends, but given how people tend to use code samples (cut-and-paste-and-modify), anyone who uses this and embeds it somewhere other than main() is going to naturally have resource issues.

I've seen this in some of the unit tests to, where we don't necessarily call clean_up on various os resource wrappers (or leave them locked, etc...). Those will get the cut-and-paste treatment too.


/*
* Now create a connection object. Note: This type is move only
Expand Down
2 changes: 1 addition & 1 deletion samples/shadow/shadow_sync/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ int main(int argc, char *argv[])
}

auto connectionOptions = tlsCtx.NewConnectionOptions();
connectionOptions.server_name = endpoint.c_str();
connectionOptions.server_name = aws_string_new_from_c_str(aws_default_allocator(), endpoint.c_str());

/*
* Now create a connection object. Note: This type is move only
Expand Down