Skip to content

Greengrass IPC #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Conversation

yourslab
Copy link
Contributor

  • Fixes the definition of the flush callback along with futures returning the expected result of the operation
  • Introduces a few mechanisms such as ProtectedPromise and mutexes to handle synchronization across multiple threads
  • Avoids usage of pointers wherever possible in place of references

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yourslab yourslab changed the base branch from main to greengrass-ipc-rough-draft May 14, 2021 17:03
int crtError;
};

template <class T> class ProtectedPromise
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this type will never be public facing and is just a helper class. Ultimately, we still return an std::future.

@yourslab
Copy link
Contributor Author

Closing for #273

@yourslab yourslab closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant