Skip to content

GG IPC #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

GG IPC #273

wants to merge 3 commits into from

Conversation

yourslab
Copy link
Contributor

@yourslab yourslab commented May 14, 2021

  • Fixes the definition of the flush callback along with futures returning the expected result of the operation
  • Introduces a few mechanisms such as ProtectedPromise and mutexes to handle synchronization across multiple threads
  • Avoids usage of pointers wherever possible in place of references

TODO

  • When the connection is no longer active or valid, trying to open a new stream or active an operation should return an error
  • Code gen will be updated to have setters and getters for each member rather than having multiple constructors for each operation payload

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yourslab yourslab mentioned this pull request May 14, 2021
Comment on lines +376 to +377
initializationPromise.set_value({EVENT_STREAM_RPC_INITIALIZATION_ERROR, 0});
return initializationPromise.get_future();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log errors

@yourslab
Copy link
Contributor Author

Closing because #287 contains the generated code

@yourslab yourslab closed this Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants