Skip to content

Integrating AWS CRT 0.5.1 into aws-crt-dev-preview #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rccarper
Copy link
Contributor

@rccarper rccarper commented Apr 1, 2020

Description

Details about the changes that I made in addition to the above branches:

  • This points the SDK to the latest build of the Java CRT available in Maven, ie, 0.5.1.
  • This required updating a handful of places where the API has changed.
  • Fixes for check-style errors.
  • I'm currently relying on the existing unit tests invoked by mvn clean install, and would be open to any other means of validating these changes if someone knows better.
  • Possible point for API discussion: the AwsCrtAsyncHttpClient now takes an EventLoopGroup and HostResolver via its builder. It would be possible to have the client create these objects itself, making a simpler experience for the user. However, because this does add the cost of an EventLoopGroup and HostResolver to each created AwsCrtAsyncHttpClient, and handling it for them potentially hides that cost, it seemed better to have the user explicitly specify their own. For example, a customer may use a pattern that creates a large number of clients, not realizing each client is spinning up an EventLoopGroup and HostResolver.

Testing

mvn clean install

[x ] I confirm that this pull request can be released under the Apache 2 license

…bc7bbeefdd9

Pull request: release <- staging/a3ea5c8b-6afb-492c-9af7-6bc7bbeefdd9
…earning Transforms and adds a new API, ListMLTransforms to support tag filtering. With this feature, customers can use tags in AWS Glue to organize and control access to Machine Learning Transforms.
…nted AI ListHumanLoops API, DescribeHumanLoop response, StartHumanLoop response and type names of SDK fields.
…TLS) between Virtual Nodes in a Mesh. Customers can use managed certificates from an AWS Certificate Manager Private Certificate Authority or bring their own certificates from the local file system to encrypt traffic between their workloads. See https://docs.aws.amazon.com/app-mesh/latest/userguide/virtual-node-tls.html for details.
…ommand and an aggregator name, performs the corresponding search on resources aggregated by the aggregator, and returns resource configurations matching the properties.
…ort sticky sessions for Network Load Balancers.
…ing of dashboards that a specific user has access to.
…61d637bc66f

Pull request: release <- staging/7386f4e3-5458-4bfa-b48d-c61d637bc66f
…d8c6ec86179

Pull request: release <- staging/29ecf595-95d3-4470-9a88-7d8c6ec86179
…etectEntitiesV2 API will provide temporal relations to existing NERe entities such as Medication, Test, Treatment, Procedure and Medical conditions.
…3922c60b95f

Pull request: release <- staging/a86c4a69-bf73-417a-a8d4-b3922c60b95f
AWS and others added 23 commits March 31, 2020 18:05
…iew, in preparation for the Detective GA release.
…atch Metrics. You can now set a policy on your container to dictate which metrics MediaStore sends to CloudWatch.
…s. In the case of a deployment rollback, the event log details the rollback reason.
…ProjectVersion APIs to Amazon Rekognition Custom Labels.
…e934a3351e4

Pull request: release <- staging/daa28b60-d856-44be-9c3f-fe934a3351e4
…s. Also fixed recognition of parameterized classes as potential document beans
@rccarper rccarper force-pushed the aws-crt-latest-api-update-dev-preview branch from 51ccc91 to 0a69d0c Compare April 2, 2020 16:15
@rccarper rccarper changed the title Aws crt latest api update dev preview Integrating AWS CRT 0.5.1 into aws-crt-dev-preview Apr 2, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2020

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 16 Code Smells

80.4% 80.4% Coverage
3.4% 3.4% Duplication

@rccarper rccarper closed this Apr 2, 2020
@rccarper rccarper deleted the aws-crt-latest-api-update-dev-preview branch April 2, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.