Skip to content

made build reproducible #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

made build reproducible #1759

wants to merge 1 commit into from

Conversation

hboutemy
Copy link

@hboutemy hboutemy commented Apr 2, 2020

Description

applied changes required as documented in https://maven.apache.org/guides/mini/guide-reproducible-builds.html
same as aws/aws-sdk-java#2223 waiting for merge...

Motivation and Context

Reproducible Builds is good for security and users trust

Testing

tested reproducibility using the recipe provided in the Maven guide (2 local builds checked against each other)

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #1759 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1759      +/-   ##
============================================
- Coverage     76.31%   76.30%   -0.01%     
  Complexity      182      182              
============================================
  Files          1072     1073       +1     
  Lines         32247    32329      +82     
  Branches       2519     2536      +17     
============================================
+ Hits          24608    24670      +62     
- Misses         6400     6413      +13     
- Partials       1239     1246       +7     
Flag Coverage Δ Complexity Δ
#unittests 76.30% <ø> (-0.01%) 182.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...ttp/nio/netty/internal/nrs/HttpStreamsHandler.java 60.76% <0.00%> (-3.85%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0.00%> (-2.86%) 0.00% <0.00%> (ø%)
...ty/internal/http2/Http2StreamExceptionHandler.java 90.90% <0.00%> (-0.76%) 0.00% <0.00%> (ø%)
...azon/awssdk/services/s3/presigner/S3Presigner.java 35.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ed/dynamodb/internal/operations/ScanOperation.java 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...d/dynamodb/internal/operations/QueryOperation.java 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...nal/http2/Http2ConnectionTerminatingException.java 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...wssdk/http/nio/netty/internal/ResponseHandler.java 89.30% <0.00%> (+0.20%) 0.00% <0.00%> (ø%)
.../enhanced/dynamodb/model/QueryEnhancedRequest.java 61.64% <0.00%> (+0.24%) 0.00% <0.00%> (ø%)
...ices/s3/internal/presigner/DefaultS3Presigner.java 88.88% <0.00%> (+0.31%) 0.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ea84f...10b4e1e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hboutemy
Copy link
Author

hboutemy commented Jun 6, 2020

@zoewangg having this library providing Reproducible Builds would be a great security enhancement: can you review, please?

aws-sdk-java-automation added a commit that referenced this pull request Oct 12, 2021
…e98dd0898

Pull request: release <- staging/ec5d9d14-a807-4e3a-85c3-f39e98dd0898
@millems
Copy link
Contributor

millems commented Sep 29, 2022

Is this update still desired? We don't mind merging a quick XML change to make things reproducible right now, but we're not looking to guarantee reproducible builds at this time (as in, we do not want to start enforcing it with testing or promise we won't ever break reproducibility).

@debora-ito
Copy link
Member

Closing this for now, as we don't intend to maintain build reproducibility at this time.

@debora-ito debora-ito closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants