Skip to content

DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc… #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc… #1832

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
85ce731
DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc…
May 13, 2020
41e794a
DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc…
May 13, 2020
3831a2a
Merge branch 'master' into batch-write-result-1831
denyskonakhevych May 13, 2020
1511c4a
Merge branch 'master' into batch-write-result-1831
denyskonakhevych May 13, 2020
4fb0f35
Merge branch 'master' into batch-write-result-1831
bmaizels May 14, 2020
4fa56a2
Fix generation for operations that share an output shape.
adamthom-amzn May 6, 2020
91288d2
Support event streams that are shared between two operations.
adamthom-amzn May 7, 2020
fe55504
Fix binding of SdkPojoSupplier to event stream type header.
adamthom-amzn May 7, 2020
550c0b1
Add support for automatically generating a presigned URL in CopyDBClu…
millems May 13, 2020
e809a49
Expose the extendedRequestId from SdkServiceException, so it can be p…
Sarev0k Apr 29, 2020
b4e5407
adding SDK version no to header
Carey-AWS May 14, 2020
4d5a3ed
Merge branch 'batch-write-result-1831' of https://github.com/denyskon…
May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...hanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/model/BatchWriteResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
import java.util.stream.Collectors;
import software.amazon.awssdk.annotations.SdkPublicApi;
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbEnhancedClient;
import software.amazon.awssdk.enhanced.dynamodb.DynamoDbTable;
import software.amazon.awssdk.enhanced.dynamodb.Key;
import software.amazon.awssdk.enhanced.dynamodb.MappedTableResource;
import software.amazon.awssdk.enhanced.dynamodb.TableMetadata;
import software.amazon.awssdk.enhanced.dynamodb.internal.operations.DefaultOperationContext;
import software.amazon.awssdk.services.dynamodb.model.DeleteRequest;
Expand All @@ -37,9 +37,9 @@
* {@link DynamoDbEnhancedClient#batchWriteItem(BatchWriteItemEnhancedRequest)}. The result describes any unprocessed items
* after the operation completes.
* <ul>
* <li>Use the {@link #unprocessedPutItemsForTable(DynamoDbTable)} method once for each table present in the request
* <li>Use the {@link #unprocessedPutItemsForTable(MappedTableResource)} method once for each table present in the request
* to get any unprocessed items from a put action on that table.</li>
* <li>Use the {@link #unprocessedDeleteItemsForTable(DynamoDbTable)} method once for each table present in the request
* <li>Use the {@link #unprocessedDeleteItemsForTable(MappedTableResource)} method once for each table present in the request
* to get any unprocessed items from a delete action on that table.</li>
* </ul>
*
Expand Down Expand Up @@ -67,7 +67,7 @@ public static Builder builder() {
* @param <T> the type of the table items
* @return a list of items
*/
public <T> List<T> unprocessedPutItemsForTable(DynamoDbTable<T> mappedTable) {
public <T> List<T> unprocessedPutItemsForTable(MappedTableResource<T> mappedTable) {
List<WriteRequest> writeRequests =
unprocessedRequests.getOrDefault(mappedTable.tableName(),
Collections.emptyList());
Expand All @@ -90,7 +90,7 @@ public <T> List<T> unprocessedPutItemsForTable(DynamoDbTable<T> mappedTable) {
* @param mappedTable the table to retrieve unprocessed items for.
* @return a list of keys that were not processed as part of the batch request.
*/
public List<Key> unprocessedDeleteItemsForTable(DynamoDbTable<?> mappedTable) {
public List<Key> unprocessedDeleteItemsForTable(MappedTableResource<?> mappedTable) {
List<WriteRequest> writeRequests =
unprocessedRequests.getOrDefault(mappedTable.tableName(),
Collections.emptyList());
Expand Down