DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc… #1832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hWriteResult when using async client (1831)
…hWriteResult when using async client (1831)
|
@dkonakhevych Changes look good. Thank you for catching this. Could you squash your commits into a single commit, and then I'd be happy to merge it for you. |
bmaizels
approved these changes
May 14, 2020
Two shapes can have the same C2J name but different intermediate model names. This seems to work fine for request types, but not response types, where the lookups were done by C2J name only.
Event stream type header values are generated from the member name in the event stream structure, not the structure name of the event itself. When the member name and the event type mismatch, then unmarshalling of events sent from the service fails. From the spec: `:event-type: This header’s value, a UTF-8 string, is derived from the event’s member name in the eventstream structure`
…sterSnapshot and CreateDBClusterPresignInterceptor when SourceRegion is specified.
…rovided to support to investigate issues
…akhevych/aws-sdk-java-v2 into batch-write-result-1831
|
SonarCloud Quality Gate failed.
|
|
@denyskonakhevych No worries, we've all been there. The trick is to get it squashed in your local repo then do a force push. I'll switch over to the other PR. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 10, 2021
…ed3fad9c5 Pull request: release <- staging/3584f3ce-f2aa-4660-b709-48ced3fad9c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BatchWriteResult requires DynamoDbTable to retrieve unprocessed put or delete items.
So there is no way to retrieve this data with DynamoDbAsyncTable.
Description
As a solution, instead of DynamoDbTable methods can accept MappedTableResource, just like it do for BatchGetResultPage::resultsForTable
Motivation and Context
Related issue: #1831
Possible Solution
As a solution, instead of DynamoDbTable methods can accept MappedTableResource, just like it do for BatchGetResultPage::resultsForTable
Types of changes
Checklist
mvn installsucceedsLicense