Skip to content

DynamoDB Enhanced: impossible to retrieve unprocessed items from Batc… #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2020

Conversation

denyskonakhevych
Copy link

Currently BatchWriteResult requires DynamoDbTable to retrieve unprocessed put or delete items.
So there is no way to retrieve this data with DynamoDbAsyncTable.

Description

As a solution, instead of DynamoDbTable methods can accept MappedTableResource, just like it do for BatchGetResultPage::resultsForTable

Motivation and Context

Related issue: #1831

Possible Solution

As a solution, instead of DynamoDbTable methods can accept MappedTableResource, just like it do for BatchGetResultPage::resultsForTable

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [ x] I have read the CONTRIBUTING document
  • [ x] Local run of mvn install succeeds
  • [ x] My code follows the code style of this project
  • [x ] My change requires a change to the Javadoc documentation
  • [x ] I have updated the Javadoc documentation accordingly
  • [ x] I have read the README document
  • I have added tests to cover my changes
  • [ x] All new and existing tests passed
  • [ x] A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [ x] I confirm that this pull request can be released under the Apache 2 license

…hWriteResult when using async client (1831)
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bmaizels bmaizels merged commit b2b805f into aws:master May 14, 2020
@bmaizels
Copy link
Contributor

Merged. Thanks for your contribution!

aws-sdk-java-automation added a commit that referenced this pull request Nov 15, 2021
…0d638610d

Pull request: release <- staging/772ba767-d673-4303-84a4-55b0d638610d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants