Skip to content

Add support for ByteBufferAttributeConverter #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

steven-aerts
Copy link
Contributor

Add support ByteBuffer as an an attribute type.

Description

The DynamoDBType already lists it as a standard type.

Motivation and Context

The DynamoDBType mentions it as a standard type, but it was not supported.

Testing

Added test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG (not sure if this is needed, please advice)
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@steven-aerts steven-aerts force-pushed the bytebufferattribute branch from 836bee2 to 6783b42 Compare June 19, 2020 13:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #1911 into master will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1911      +/-   ##
============================================
+ Coverage     76.24%   76.27%   +0.03%     
  Complexity      187      187              
============================================
  Files          1076     1077       +1     
  Lines         32573    32585      +12     
  Branches       2569     2569              
============================================
+ Hits          24835    24854      +19     
+ Misses         6478     6474       -4     
+ Partials       1260     1257       -3     
Flag Coverage Δ Complexity Δ
#unittests 76.27% <83.33%> (+0.03%) 187.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
...verter/attribute/ByteBufferAttributeConverter.java 81.81% <81.81%> (ø) 0.00 <0.00> (?)
...ed/dynamodb/DefaultAttributeConverterProvider.java 97.82% <100.00%> (+0.02%) 0.00 <0.00> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 87.61% <0.00%> (+2.85%) 0.00% <0.00%> (ø%)
...k/core/pagination/async/ResponsesSubscription.java 84.00% <0.00%> (+16.00%) 0.00% <0.00%> (ø%)
...mazon/awssdk/utils/async/DelegatingSubscriber.java 100.00% <0.00%> (+22.22%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc38805...e4d7ce3. Read the comment docs.

@steven-aerts steven-aerts force-pushed the bytebufferattribute branch from 6783b42 to e4d7ce3 Compare June 23, 2020 07:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@steven-aerts
Copy link
Contributor Author

Hi,

I am wondering if there is anything I can do to get this code change merged.

I think it is a missing feature which is useful for everybody.

Steven

@steven-aerts steven-aerts force-pushed the bytebufferattribute branch from e4d7ce3 to a5ae4b9 Compare April 2, 2021 06:25
Add support ByteBuffer as an an attribute type.
The DynamoDBType already lists it as a standard type.
@steven-aerts steven-aerts force-pushed the bytebufferattribute branch from a5ae4b9 to 1922e0c Compare April 2, 2021 06:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@joviegas joviegas merged commit e59216d into aws:master Apr 2, 2021
aws-sdk-java-automation added a commit that referenced this pull request Jan 24, 2022
…282f4cf66

Pull request: release <- staging/e9450161-1693-4a2b-a029-4b7282f4cf66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants