-
Notifications
You must be signed in to change notification settings - Fork 914
Add support for ByteBufferAttributeConverter #1911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 changes: 91 additions & 0 deletions
91
...n/awssdk/enhanced/dynamodb/internal/converter/attribute/ByteBufferAttributeConverter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.enhanced.dynamodb.internal.converter.attribute; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
| import software.amazon.awssdk.annotations.Immutable; | ||
| import software.amazon.awssdk.annotations.SdkInternalApi; | ||
| import software.amazon.awssdk.annotations.ThreadSafe; | ||
| import software.amazon.awssdk.core.SdkBytes; | ||
| import software.amazon.awssdk.enhanced.dynamodb.AttributeConverter; | ||
| import software.amazon.awssdk.enhanced.dynamodb.AttributeValueType; | ||
| import software.amazon.awssdk.enhanced.dynamodb.EnhancedType; | ||
| import software.amazon.awssdk.enhanced.dynamodb.internal.converter.TypeConvertingVisitor; | ||
| import software.amazon.awssdk.services.dynamodb.model.AttributeValue; | ||
|
|
||
|
|
||
| /** | ||
| * A converter between {@link ByteBuffer} and {@link AttributeValue}. | ||
| * | ||
| * <p> | ||
| * This stores values in DynamoDB as a binary blob. | ||
| * | ||
| * <p> | ||
| * This supports reading every byte value supported by DynamoDB, making it fully compatible with custom converters as | ||
| * well as internal converters (e.g. {@link SdkBytesAttributeConverter}). | ||
| * | ||
| * <p> | ||
| * This can be created via {@link #create()}. | ||
| */ | ||
| @SdkInternalApi | ||
| @ThreadSafe | ||
| @Immutable | ||
| public final class ByteBufferAttributeConverter implements AttributeConverter<ByteBuffer> { | ||
| private static final Visitor VISITOR = new Visitor(); | ||
|
|
||
| private ByteBufferAttributeConverter() { | ||
| } | ||
|
|
||
| public static ByteBufferAttributeConverter create() { | ||
| return new ByteBufferAttributeConverter(); | ||
| } | ||
|
|
||
| @Override | ||
| public EnhancedType<ByteBuffer> type() { | ||
| return EnhancedType.of(ByteBuffer.class); | ||
| } | ||
|
|
||
| @Override | ||
| public AttributeValueType attributeValueType() { | ||
| return AttributeValueType.B; | ||
| } | ||
|
|
||
| @Override | ||
| public AttributeValue transformFrom(ByteBuffer input) { | ||
| return AttributeValue.builder().b(SdkBytes.fromByteBuffer(input)).build(); | ||
| } | ||
|
|
||
| @Override | ||
| public ByteBuffer transformTo(AttributeValue input) { | ||
| if (input.b() != null) { | ||
| return EnhancedAttributeValue.fromBytes(input.b()).convert(VISITOR); | ||
| } | ||
|
|
||
| return EnhancedAttributeValue.fromAttributeValue(input).convert(VISITOR); | ||
| } | ||
|
|
||
| private static final class Visitor extends TypeConvertingVisitor<ByteBuffer> { | ||
| private Visitor() { | ||
| super(ByteBuffer.class, ByteBufferAttributeConverter.class); | ||
| } | ||
|
|
||
| @Override | ||
| public ByteBuffer convertBytes(SdkBytes value) { | ||
| return value.asByteBuffer(); | ||
| } | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...are/amazon/awssdk/enhanced/dynamodb/functionaltests/models/FakeItemWithByteBufferKey.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"). | ||
| * You may not use this file except in compliance with the License. | ||
| * A copy of the License is located at | ||
| * | ||
| * http://aws.amazon.com/apache2.0 | ||
| * | ||
| * or in the "license" file accompanying this file. This file is distributed | ||
| * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package software.amazon.awssdk.enhanced.dynamodb.functionaltests.models; | ||
|
|
||
| import software.amazon.awssdk.core.SdkBytes; | ||
| import software.amazon.awssdk.enhanced.dynamodb.mapper.StaticTableSchema; | ||
|
|
||
| import java.nio.ByteBuffer; | ||
| import java.util.Objects; | ||
|
|
||
| import static software.amazon.awssdk.enhanced.dynamodb.mapper.StaticAttributeTags.primaryPartitionKey; | ||
|
|
||
| public class FakeItemWithByteBufferKey { | ||
| private static final StaticTableSchema<FakeItemWithByteBufferKey> FAKE_ITEM_WITH_BINARY_KEY_SCHEMA = | ||
| StaticTableSchema.builder(FakeItemWithByteBufferKey.class) | ||
| .newItemSupplier(FakeItemWithByteBufferKey::new) | ||
| .addAttribute(SdkBytes.class, a -> a.name("id") | ||
| .getter(FakeItemWithByteBufferKey::getIdAsSdkBytes) | ||
| .setter(FakeItemWithByteBufferKey::setIdAsSdkBytes) | ||
| .tags(primaryPartitionKey())) | ||
| .build(); | ||
|
|
||
| private ByteBuffer id; | ||
|
|
||
| public static StaticTableSchema<FakeItemWithByteBufferKey> getTableSchema() { | ||
| return FAKE_ITEM_WITH_BINARY_KEY_SCHEMA; | ||
| } | ||
|
|
||
| public ByteBuffer getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public void setId(ByteBuffer id) { | ||
| this.id = id; | ||
| } | ||
|
|
||
|
|
||
| public SdkBytes getIdAsSdkBytes() { | ||
| return SdkBytes.fromByteBuffer(id); | ||
| } | ||
|
|
||
| public void setIdAsSdkBytes(SdkBytes id) { | ||
| this.id = id.asByteBuffer(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; | ||
| FakeItemWithByteBufferKey that = (FakeItemWithByteBufferKey) o; | ||
| return Objects.equals(id, that.id); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(id); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.