Master update #2072
Merged
Master update #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation of JMESPath expressions for waiter acceptors. The added JmesPathParser.parse method can convert a valid JMESPath expression into an Expression, which is a syntax tree representation of an JMESPath expression. The next step will be to interpret this JMESPath expression to generate an acceptor for waiters. It's likely that this interpreter will only implement a subset of the JMESPath features.
This required the following changes: 1. Added a JMES Path interpreter based on the JMES Path parser from a previous commit. This interpreter is in the code generator and creates the Java instructions for executing the acceptor logic. 2. Added the code generator logic for specifying the acceptors. 3. Added a Waiters runtime that is currently shared between all service clients, used by the acceptors of all services. 4. Added a "MemberName" field to the SDK field metadata, so that it can be referenced by the waiter code (waiters refer to the member names from the C2J). 5. Added tests for the two most complex waiter classes: AutoScaling and ECS 6. Added support for acceptors matching supertypes of the response type. Waiters should mostly be working now, but there are a few remaining tasks: 1. There's a WaitersRuntime component in sdk-core that should be copied to each of the service to remove them as a protected API. 2. Waiters currently only support the JMESPath syntax currently used by services. We should add support for some of the other 'easier' JMESPath syntax so that we're future-compatible with more waiters.
This keeps the runtime as a private implementation detail and no longer a backwards compat concern as it would be if left as an SdkProtectedApi.
…ore number, fix javadocs, remove unnecessary logs fix duplicate if statement in Expression
Fixed a bug where an exception thrown in waiterAcceptor could cause the async waiter operations to hang Add request override config overload in Waiter
zoewangg
reviewed
Sep 29, 2020
|
@zoewangg Done! Added an entry and kicked off a integ test run. |
dagnir
force-pushed
the
master-update
branch
from
3c683d2 to
acf00fc
Compare
zoewangg
approved these changes
Sep 29, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 1, 2022
…ba31af43a Pull request: release <- staging/4609ffa1-520f-41ee-aecf-401ba31af43a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge in
masterbranch and bump version to2.15.0-SNAPSHOT.Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense