Skip to content

Master update #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 30, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
34f3b99
Implement generic Waiter functionality
zoewangg Jul 17, 2020
5465193
Merge remote-tracking branch 'origin/master' into waiters-development
zoewangg Aug 26, 2020
b5489c5
Add waiter generator task
zoewangg Sep 8, 2020
2933e22
Generate service specific waiter sync and async interfaces
zoewangg Sep 9, 2020
5dd15f7
Update codegen module to generate service waiter implementation classes
zoewangg Sep 11, 2020
871996a
Add JMESPath parsing logic to the code generator, preparing for evalu…
millems Sep 2, 2020
7134917
Add waiter generator task
zoewangg Sep 8, 2020
e371de4
Add support for generating waiter acceptors.
millems Sep 8, 2020
b154ef3
Make WaitersRuntime a per-service private class
dagnir Sep 17, 2020
57a47d5
Append userAgent for Waiters operations
Quanzzzz Sep 16, 2020
6435cb9
Add consumer builder overload for waiter methods and pollingStrategy …
zoewangg Sep 21, 2020
5f04da3
Add static create method in generated service waiters
zoewangg Sep 21, 2020
6edb663
Various small fixes - change the default scheduled executor service c…
zoewangg Sep 23, 2020
ebf0fda
Various renaming. Create default values for waiterOverrideConfiguration
zoewangg Sep 23, 2020
ed1b2ca
Add functional tests and integration tests
Quanzzzz Sep 23, 2020
45fa52c
Adjust the Waiters related javadocs
Quanzzzz Sep 25, 2020
ead3b78
Add request level override config overload
zoewangg Sep 25, 2020
07cf6e0
Fix javadocs, add more tests, remove unncessary methods
zoewangg Sep 29, 2020
22b6687
Merge remote-tracking branch 'origin/master' into master-update
dagnir Sep 29, 2020
72e69aa
Add changelog entry for waiters
dagnir Sep 29, 2020
34b8999
Merge remote-tracking branch 'origin/master' into master-update
dagnir Sep 29, 2020
acf00fc
Bump version to 2.15.0-SNAPSHOT
dagnir Sep 29, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 5 additions & 0 deletions .changes/next-release/feature-AWSSDKforJavav2-aa99eac.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "feature",
"category": "AWS SDK for Java v2",
"description": "This release introduces Waiters for the AWS SDK for Java v2! Waiters make it easier for customers to wait for a resource to transition into a desired state. It comes handy when customers are interacting with operations that are eventually consistent on the service side. For more information on Waiters, head on over to the [AWS Developer Blog](https://aws.amazon.com/blogs/developer/category/developer-tools/aws-sdk-for-java/) and check out the [Developer Guide](http://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/welcome.html)."
}
2 changes: 1 addition & 1 deletion archetypes/archetype-lambda/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>archetypes</artifactId>
<groupId>software.amazon.awssdk</groupId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<artifactId>archetype-lambda</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion archetypes/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>aws-sdk-java-pom</artifactId>
<groupId>software.amazon.awssdk</groupId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>
<artifactId>archetypes</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion aws-sdk-java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>aws-sdk-java</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion bom-internal/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>aws-sdk-java-pom</artifactId>
<groupId>software.amazon.awssdk</groupId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
2 changes: 1 addition & 1 deletion bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>bom</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@
</Not>
</Match>

<Match>
<Class name="software.amazon.awssdk.core.internal.waiters.ResponseOrException"/>
<Bug pattern="NM_CLASS_NOT_EXCEPTION"/>
</Match>

<Match>
<Package name="~software.amazon.awssdk.http.*"/>
<Bug pattern="URF_UNREAD_FIELD, RV_RETURN_VALUE_IGNORED"/>
Expand Down
2 changes: 1 addition & 1 deletion bundle/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<artifactId>bundle</artifactId>
<packaging>jar</packaging>
Expand Down
2 changes: 1 addition & 1 deletion codegen-lite-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>codegen-lite-maven-plugin</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion codegen-lite/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<artifactId>codegen-lite</artifactId>
<name>AWS Java SDK :: Code Generator Lite</name>
Expand Down
2 changes: 1 addition & 1 deletion codegen-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>codegen-maven-plugin</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion codegen/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>software.amazon.awssdk</groupId>
<artifactId>aws-sdk-java-pom</artifactId>
<version>2.14.29-SNAPSHOT</version>
<version>2.15.0-SNAPSHOT</version>
</parent>
<artifactId>codegen</artifactId>
<name>AWS Java SDK :: Code Generator</name>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public static Metadata constructMetadata(ServiceModel serviceModel,
.withTransformPackageName(namingStrategy.getTransformPackageName(serviceName))
.withRequestTransformPackageName(namingStrategy.getRequestTransformPackageName(serviceName))
.withPaginatorsPackageName(namingStrategy.getPaginatorsPackageName(serviceName))
.withWaitersPackageName(namingStrategy.getWaitersPackageName(serviceName))
.withServiceAbbreviation(serviceMetadata.getServiceAbbreviation())
.withServiceFullName(serviceMetadata.getServiceFullName())
.withServiceName(serviceName)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import software.amazon.awssdk.codegen.model.service.Operation;
import software.amazon.awssdk.codegen.model.service.Paginators;
import software.amazon.awssdk.codegen.model.service.ServiceModel;
import software.amazon.awssdk.codegen.model.service.Waiters;
import software.amazon.awssdk.codegen.naming.DefaultNamingStrategy;
import software.amazon.awssdk.codegen.naming.NamingStrategy;
import software.amazon.awssdk.utils.CollectionUtils;
Expand All @@ -59,6 +60,7 @@ public class IntermediateModelBuilder {
private final TypeUtils typeUtils;
private final List<IntermediateModelShapeProcessor> shapeProcessors;
private final Paginators paginators;
private final Waiters waiters;

public IntermediateModelBuilder(C2jModels models) {
this.customConfig = models.customizationConfig();
Expand All @@ -67,6 +69,7 @@ public IntermediateModelBuilder(C2jModels models) {
this.typeUtils = new TypeUtils(namingStrategy);
this.shapeProcessors = createShapeProcessors();
this.paginators = models.paginatorsModel();
this.waiters = models.waitersModel();
}


Expand Down Expand Up @@ -130,7 +133,8 @@ public IntermediateModel build() {

IntermediateModel fullModel = new IntermediateModel(
constructMetadata(service, customConfig), operations, shapes,
customConfig, endpointOperation, authorizers, paginators.getPagination(), namingStrategy);
customConfig, endpointOperation, authorizers, paginators.getPagination(), namingStrategy,
waiters.getWaiters());

customization.postprocess(fullModel);

Expand All @@ -149,7 +153,8 @@ public IntermediateModel build() {
endpointOperation,
fullModel.getCustomAuthorizers(),
fullModel.getPaginators(),
namingStrategy);
namingStrategy,
fullModel.getWaiters());

linkMembersToShapes(trimmedModel);
linkOperationsToInputOutputShapes(trimmedModel);
Expand Down
Loading