Skip to content

Fix inconsistency of checksunValidationEnabled between default S3Configuration and no S3Configuration #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2021

Conversation

Quanzzzz
Copy link
Contributor

@Quanzzzz Quanzzzz commented Jan 8, 2021

Change the default value of checksumValidationEnabled as false to achieve parity between presigners with the default S3Configuration and no S3Cofiguration, to avoid signatureNotMatched error while using the presigned url in browser with the default S3Configuration.

Description

Motivation and Context

#2154

Testing

Unit tests added.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@Quanzzzz Quanzzzz force-pushed the presigner-debug branch 2 times, most recently from 1714fd3 to 2963f76 Compare January 9, 2021 00:03
@Quanzzzz Quanzzzz force-pushed the presigner-debug branch 2 times, most recently from 82a126c to d7031ab Compare January 9, 2021 01:41
@codecov-io
Copy link

Codecov Report

Merging #2231 (1714fd3) into master (11abeb8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2231      +/-   ##
============================================
+ Coverage     77.62%   77.63%   +0.01%     
  Complexity      335      335              
============================================
  Files          1230     1231       +1     
  Lines         38713    38726      +13     
  Branches       3045     3047       +2     
============================================
+ Hits          30052    30066      +14     
+ Misses         7201     7200       -1     
  Partials       1460     1460              
Flag Coverage Δ Complexity Δ
unittests 77.63% <100.00%> (+0.01%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ices/s3/internal/presigner/DefaultS3Presigner.java 90.96% <100.00%> (+0.15%) 0.00 <0.00> (ø)
...ty/internal/IdleConnectionCountingChannelPool.java 85.36% <0.00%> (-3.66%) 0.00% <0.00%> (ø%)
...dk/http/nio/netty/internal/SslContextProvider.java 90.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...p/nio/netty/internal/AwaitCloseChannelPoolMap.java 92.45% <0.00%> (+1.97%) 0.00% <0.00%> (ø%)
...nio/netty/internal/OldConnectionReaperHandler.java 90.90% <0.00%> (+9.09%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11abeb8...d7031ab. Read the comment docs.

@Quanzzzz Quanzzzz merged commit c64762d into aws:master Jan 9, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

aws-sdk-java-automation added a commit that referenced this pull request Nov 1, 2022
…869c349b6

Pull request: release <- staging/353e8a1f-dc77-483e-befd-5df869c349b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants