Don't create object if no implicit members #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
rest-json-implicit-members
branch
2 times, most recently
from
3ab6c58 to
5340f2c
Compare
This fixes an edge case in the REST-JSON marshaller: if the request has neither
an explicit payload nor implicit payload members (i.e. members not explicitly
bound to an location), then the marshaller should not create an create an
object. i.e. the request body should be "", and not "{}".
dagnir
force-pushed
the
rest-json-implicit-members
branch
from
5340f2c to
92a3766
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dagnir
changed the title
cenedhryn
approved these changes
Oct 19, 2021
...ain/java/software/amazon/awssdk/protocols/json/internal/marshall/JsonProtocolMarshaller.java
Show resolved
Hide resolved
dagnir
added a commit
that referenced
this pull request
Oct 21, 2021
* Add REST-JSON Content-Type tests (#2756) Add SDK standard test cases that verify correct conte-type handling for the REST-JSON protocol. * Follow standard REST-JSON content-type handling (#2765) * Follow standard REST-JSON content-type handling Update the REST-JSON marshalling logic to conform to the standard expected behavior WRT to the `Content-Type` of the request. * Add additional protocol test Verifies that when there are unbound members (no `location` trait), and they are null, that we continue to marshall to an empty JSON object in the body. * Extract block to method * Don't create object if no implicit members (#2773) This fixes an edge case in the REST-JSON marshaller: if the request has neither an explicit payload nor implicit payload members (i.e. members not explicitly bound to an location), then the marshaller should not create an create an object. i.e. the request body should be "", and not "{}".
dagnir
added a commit
that referenced
this pull request
Nov 15, 2021
* Add REST-JSON Content-Type tests (#2756) Add SDK standard test cases that verify correct conte-type handling for the REST-JSON protocol. * Follow standard REST-JSON content-type handling (#2765) * Follow standard REST-JSON content-type handling Update the REST-JSON marshalling logic to conform to the standard expected behavior WRT to the `Content-Type` of the request. * Add additional protocol test Verifies that when there are unbound members (no `location` trait), and they are null, that we continue to marshall to an empty JSON object in the body. * Extract block to method * Don't create object if no implicit members (#2773) This fixes an edge case in the REST-JSON marshaller: if the request has neither an explicit payload nor implicit payload members (i.e. members not explicitly bound to an location), then the marshaller should not create an create an object. i.e. the request body should be "", and not "{}". * Fix rest-json marshalling for events (#2805) Correctly propagate the existence of implicit event members down to the marshaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Bug fix.
Description
This fixes an edge case in the REST-JSON marshaller: if the request has neither
an explicit payload nor implicit payload members (i.e. members not explicitly
bound to an location), then the marshaller should not create an create an
object. i.e. the request body should be "", and not "{}".
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense