-
Notifications
You must be signed in to change notification settings - Fork 914
Migrate most tests to JUnit 5 #2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Bennett-Lynch
merged 7 commits into
aws:master
from
Bennett-Lynch:junit5-migration-step2c
Dec 23, 2021
Merged
Migrate most tests to JUnit 5 #2931
Bennett-Lynch
merged 7 commits into
aws:master
from
Bennett-Lynch:junit5-migration-step2c
Dec 23, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed!
|
dagnir
approved these changes
Dec 23, 2021
dagnir
approved these changes
Dec 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure the JDK8 build job is passing before merging
Bennett-Lynch
pushed a commit
to Bennett-Lynch/aws-sdk-java-v2
that referenced
this pull request
Jan 14, 2022
…ert "Migrate most tests to JUnit 5 (aws#2931)" This partially reverts commit abe96fd (aws#2931). Only tests that use org.junit.Rule are reverted as they are not compatible with JUnit 5. This also upgrades surefire-junit47 to surefire-junit-platform to be compatible with the junit-jupiter test platform.
1 task
Bennett-Lynch
added a commit
that referenced
this pull request
Jan 14, 2022
…ert "Migrate most tests to JUnit 5 (#2931)" (#2970) Upgrade surefire-junit47 to surefire-junit-platform and partially revert "Migrate most tests to JUnit 5 (#2931)" This partially reverts commit abe96fd (#2931). Only tests that use org.junit.Rule are reverted as they are not compatible with JUnit 5. This also upgrades surefire-junit47 to surefire-junit-platform to be compatible with the junit-jupiter test platform.
aws-sdk-java-automation
added a commit
that referenced
this pull request
Mar 21, 2024
…dbe5e1150 Pull request: release <- staging/ac5315e1-acb2-4b18-bb3a-079dbe5e1150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 4 -> 5 migrations are often done in a 3-step process:
This PR begins step 2 by migrating tests which can be easily converted.
This PR excludes JUnit 4 tests which leverage any of the following:
expected
parameter in test annotationstimeout
parameter in test annotations@RunWith
annotation (e.g.,@RunWith(Parameterized.class)
and@RunWith(MockitoJUnitRunner.class)
)License