Upgrade surefire-junit47 to surefire-junit-platform and partially revert "Migrate most tests to JUnit 5 (#2931)" #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert "Migrate most tests to JUnit 5 (aws#2931)" This partially reverts commit abe96fd (aws#2931). Only tests that use org.junit.Rule are reverted as they are not compatible with JUnit 5. This also upgrades surefire-junit47 to surefire-junit-platform to be compatible with the junit-jupiter test platform.
added 11 commits
January 13, 2022 21:02
|
Kudos, SonarCloud Quality Gate passed!
|
millems
approved these changes
Jan 14, 2022
Manually verified locally that both JUnit4 and JUnit5 tests are being correctly run. Beyond that I'm not sure. Perhaps the SonarCloud coverage report. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 11, 2024
…e2d0f9790 Pull request: release <- staging/6a35aa08-9adb-4060-981e-b02e2d0f9790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit abe96fd (#2931). Only tests that use
org.junit.Ruleare reverted as they are not compatible with JUnit 5.This also upgrades
surefire-junit47tosurefire-junit-platformto be compatible with thejunit-jupitertest platform.License