Move S3 CRT related class out of s3-tranfer-manager module to s3 module #3195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
May 16, 2022
| @@ -13,7 +13,7 @@ | |||
| * permissions and limitations under the License. | |||
| */ | |||
|
|
|||
| package software.amazon.awssdk.transfer.s3.internal; | |||
| package software.amazon.awssdk.services.s3.internal.crt; | |||
There was a problem hiding this comment.
We will make this class public API before GA
| <groupId>software.amazon.awssdk.crt</groupId> | ||
| <artifactId>aws-crt</artifactId> | ||
| <version>${awscrt.version}</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
Dependencies of provided scope are not transitive.
dagnir
reviewed
May 16, 2022
.../src/main/java/software/amazon/awssdk/services/s3/internal/crt/AbstractS3CrtAsyncClient.java
Outdated
Show resolved
Hide resolved
zoewangg
force-pushed
the
zoewang/moveS3CrtAsyncClient
branch
2 times, most recently
from
2953c67 to
37633f2
Compare
zoewangg
force-pushed
the
zoewang/moveS3CrtAsyncClient
branch
from
37633f2 to
823c025
Compare
dagnir
approved these changes
May 17, 2022
|
SonarCloud Quality Gate failed. |
zoewangg
added a commit
that referenced
this pull request
May 24, 2022
…le (#3195) * Move S3 CRT related class from s3-tranfer-manager module to s3 module * Update AbstractS3AsyncClient
1 task
aws-sdk-java-automation
added a commit
that referenced
this pull request
Aug 23, 2024
…914202dff Pull request: release <- staging/01f70015-7c37-4d48-827a-ba3914202dff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Move S3 CRT related class out of s3-tranfer-manager module to s3 module
Testing
Integ tests passed