Skip to content

Remove leftover TODOs #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2022
Merged

Remove leftover TODOs #3514

merged 3 commits into from
Nov 7, 2022

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Oct 24, 2022

Motivation and Context

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir requested a review from a team as a code owner October 24, 2022 22:46
@dagnir dagnir force-pushed the dongie/remove-todos branch from efadf1d to 1b3349e Compare October 24, 2022 23:07
@dagnir dagnir force-pushed the dongie/remove-todos branch from 1b3349e to 02cf966 Compare October 25, 2022 21:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dagnir dagnir merged commit 036d0e3 into master Nov 7, 2022
aws-sdk-java-automation added a commit that referenced this pull request Dec 10, 2024
@aws-sdk-java-automation
Merge pull request #3514 from aws/staging/79f76a48-2328-4560-ac4c-164…
7532778 
…ae974788c

Pull request: release <- staging/79f76a48-2328-4560-ac4c-164ae974788c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millems millems millems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @millems