Skip to content

Remove leftover TODOs #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Remove leftover TODOs #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cf966
Remove leftover TODOs
dagnir Oct 24, 2022
74e8851
Merge branch 'master' into dongie/remove-todos
dagnir Oct 25, 2022
a7ea73e
Merge branch 'master' into dongie/remove-todos
dagnir Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ private MethodSpec ruleParams() {
case AWS_S3_CONTROL_USE_ARN_REGION:
// end of S3 specific builtins
case AWS_STS_USE_GLOBAL_ENDPOINT:
// TODO: handle this
// V2 doesn't support this, only regional endpoints
return;
default:
throw new RuntimeException("Don't know how to set built-in " + m.getBuiltInEnum());
Expand Down
7 changes: 5 additions & 2 deletions ...java/software/amazon/awssdk/services/s3/internal/endpoints/UseGlobalEndpointResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@
import software.amazon.awssdk.profiles.ProfileProperty;
import software.amazon.awssdk.regions.Region;
import software.amazon.awssdk.regions.ServiceMetadataAdvancedOption;
import software.amazon.awssdk.regions.servicemetadata.EnhancedS3ServiceMetadata;
import software.amazon.awssdk.utils.Lazy;
import software.amazon.awssdk.utils.Logger;

/**
* Note: Most of the logic is copied from EnhancedS3ServiceMetadata
* // TODO: should probably refactor that class to reuse the same logic
* Resolve the use global endpoint setting for S3.
* <p>
* This logic is identical to that in {@link EnhancedS3ServiceMetadata}, there's no good way to share it aside from creating a
* protected API that both the s3 and regions module consume.
*/
@SdkInternalApi
public class UseGlobalEndpointResolver {
Expand Down