Skip to content

Issue #3761 - add culprit classnames to provider error messages #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 11, 2023
Merged

Issue #3761 - add culprit classnames to provider error messages #3762

merged 6 commits into from
Mar 11, 2023

Conversation

barryoneill
Copy link
Contributor

Add the class names of the discovered providers to the provider failure messages.

Motivation and Context

Issue #3761

Modifications

  • load all the discovered implementations into a list (for http provider impls, it really shouldn't be more than a handful at worst)
  • Format them into a "[fqdn1,fqdn2,fqdnN]" format
  • Append them to the error message.

Testing

Existing tests cover that the existing logic is not broken. There appear to be no tests around the actual message content, but I can add this if needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@barryoneill barryoneill requested a review from a team as a code owner February 15, 2023 20:33
@dagnir
Copy link
Contributor

dagnir commented Mar 10, 2023

LGTM! Thanks for the contribution.

dagnir
dagnir reviewed Mar 10, 2023
View reviewed changes
...n/java/software/amazon/awssdk/core/internal/http/loader/ClasspathSdkHttpServiceProvider.java Outdated
String implText =
impls.stream()
.map(clazz -> clazz.getClass().getName())
.collect(Collectors.joining(",","[","]"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like checkstyle wants a space between the arguments here. Can you add those?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, done!

@dagnir dagnir enabled auto-merge (squash) March 10, 2023 22:39
@dagnir dagnir merged commit 8a68ef9 into aws:master Mar 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@barryoneill
Copy link
Contributor Author

Thanks @dagnir.

@dagnir
Copy link
Contributor

dagnir commented Mar 13, 2023

@all-contributors please add @barryoneill for code

@allcontributors allcontributors bot mentioned this pull request Mar 13, 2023
Merged
@allcontributors
Copy link
Contributor

@dagnir

I've put up a pull request to add @barryoneill! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barryoneill @dagnir