Skip to content

Issue #3761 - add culprit classnames to provider error messages #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2023
Merged

Issue #3761 - add culprit classnames to provider error messages #3762

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccc6119
Issue #3761 - add culprit classnames to provider error messages
barryoneill Feb 15, 2023
8cf0801
Merge branch 'master' into master
barryoneill Feb 16, 2023
b1fc96c
Merge branch 'master' into master
barryoneill Feb 17, 2023
efb176d
Merge branch 'master' into master
barryoneill Feb 21, 2023
f2e7267
Merge branch 'master' into master
barryoneill Mar 10, 2023
c62c893
Fix checkstyle errors
barryoneill Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions ...ava/software/amazon/awssdk/core/internal/http/loader/ClasspathSdkHttpServiceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@

package software.amazon.awssdk.core.internal.http.loader;

import java.util.Iterator;
import java.util.List;
import java.util.Optional;
import java.util.ServiceLoader;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;
import software.amazon.awssdk.annotations.SdkInternalApi;
import software.amazon.awssdk.annotations.SdkTestInternalApi;
import software.amazon.awssdk.core.SdkSystemSetting;
Expand Down Expand Up @@ -46,22 +48,33 @@ final class ClasspathSdkHttpServiceProvider<T> implements SdkHttpServiceProvider

@Override
public Optional<T> loadService() {
Iterator<T> httpServices = serviceLoader.loadServices(serviceClass);
if (!httpServices.hasNext()) {
Iterable<T> iterable = () -> serviceLoader.loadServices(serviceClass);
List<T> impls = StreamSupport
.stream(iterable.spliterator(), false)
.collect(Collectors.toList());

if (impls.isEmpty()) {
return Optional.empty();
}
T httpService = httpServices.next();

if (httpServices.hasNext()) {
if (impls.size() > 1) {

String implText =
impls.stream()
.map(clazz -> clazz.getClass().getName())
.collect(Collectors.joining(",", "[", "]"));

throw SdkClientException.builder().message(
String.format(
"Multiple HTTP implementations were found on the classpath. To avoid non-deterministic loading " +
"implementations, please explicitly provide an HTTP client via the client builders, set the %s " +
"system property with the FQCN of the HTTP service to use as the default, or remove all but one " +
"HTTP implementation from the classpath", implSystemProperty.property()))
"HTTP implementation from the classpath. The multiple implementations found were: %s",
implSystemProperty.property(), implText))
.build();
}
return Optional.of(httpService);

return impls.stream().findFirst();
}

/**
Expand Down