Fix flaky IMDS client test #3912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
dongie/fix-imds-client-test
branch
from
a81a68e to
9aef3db
Compare
This test should be less flaky since the mock client should never trigger the retry logic in the IMDS client by sometimes returning a 500.
dagnir
force-pushed
the
dongie/fix-imds-client-test
branch
from
9aef3db to
a893f54
Compare
zoewangg
approved these changes
Apr 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 19, 2023
…#2467) * Update to next snapshot version: 2.20.49-SNAPSHOT * Fix flaky IMDS client test (#3912) This test should be less flaky since the mock client should never trigger the retry logic in the IMDS client by sometimes returning a 500. * Add TrustAllCertificates in CRT S3 Client options (#3903) * Add TrustAllCertificates in CRT S3 Client options * Handled PR comments * Amazon Relational Database Service Update: Adds support for the ImageId parameter of CreateCustomDBEngineVersion to RDS Custom for Oracle * AWS SecurityHub Update: Update that adds SDK code examples for Security Hub * Amazon Comprehend Update: This release supports native document models for custom classification, in addition to plain-text models. You train native document models using documents (PDF, Word, images) in their native format. * Amazon Simple Storage Service Update: Provides support for "Snow" Storage class. * Amazon EC2 Container Service Update: This release supports the Account Setting "TagResourceAuthorization" that allows for enhanced Tagging security controls. * AWS Secrets Manager Update: Documentation updates for Secrets Manager * AWS S3 Control Update: Provides support for overriding endpoint when region is "snow". This will enable bucket APIs for Amazon S3 Compatible storage on Snow Family devices. * AWS Resource Access Manager Update: This release adds support for customer managed permissions. Customer managed permissions enable customers to author and manage tailored permissions for resources shared using RAM. * Updated endpoints.json and partitions.json. * Release 2.20.49. Updated CHANGELOG.md, README.md and all pom.xml. --------- Co-authored-by: AWS <> Co-authored-by: Dongie Agnir <[email protected]> Co-authored-by: John Viegas <[email protected]>
millems
added a commit
that referenced
this pull request
Apr 19, 2023
* Pull request: release <- staging/31d9787e-9a7d-4544-bbf2-ffb44eac702a (#2467) * Update to next snapshot version: 2.20.49-SNAPSHOT * Fix flaky IMDS client test (#3912) This test should be less flaky since the mock client should never trigger the retry logic in the IMDS client by sometimes returning a 500. * Add TrustAllCertificates in CRT S3 Client options (#3903) * Add TrustAllCertificates in CRT S3 Client options * Handled PR comments * Amazon Relational Database Service Update: Adds support for the ImageId parameter of CreateCustomDBEngineVersion to RDS Custom for Oracle * AWS SecurityHub Update: Update that adds SDK code examples for Security Hub * Amazon Comprehend Update: This release supports native document models for custom classification, in addition to plain-text models. You train native document models using documents (PDF, Word, images) in their native format. * Amazon Simple Storage Service Update: Provides support for "Snow" Storage class. * Amazon EC2 Container Service Update: This release supports the Account Setting "TagResourceAuthorization" that allows for enhanced Tagging security controls. * AWS Secrets Manager Update: Documentation updates for Secrets Manager * AWS S3 Control Update: Provides support for overriding endpoint when region is "snow". This will enable bucket APIs for Amazon S3 Compatible storage on Snow Family devices. * AWS Resource Access Manager Update: This release adds support for customer managed permissions. Customer managed permissions enable customers to author and manage tailored permissions for resources shared using RAM. * Updated endpoints.json and partitions.json. * Release 2.20.49. Updated CHANGELOG.md, README.md and all pom.xml. --------- Co-authored-by: AWS <> Co-authored-by: Dongie Agnir <[email protected]> Co-authored-by: John Viegas <[email protected]> * Remove unnecessary ACL integration test for S3. (#2468) * Update to next snapshot version: 2.20.50-SNAPSHOT --------- Co-authored-by: aws-sdk-java-automation <[email protected]> Co-authored-by: Dongie Agnir <[email protected]> Co-authored-by: John Viegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This test should be less flaky since the mock client should never trigger the retry logic in the IMDS client by sometimes returning a 500.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License